🤖 fix: remove duplicate server arg from Coder control plane#40
Merged
Conversation
The Coder container image already uses an entrypoint of '/opt/coder server'. Passing "server" in the reconciled Deployment args produced an effective command of 'coder server server ...', causing control plane pods to crash with an unrecognized subcommand error. Update the default args to pass only flags, and keep extraArgs appended. Extend the controller reconcile test to assert the generated args. Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`mux`](https://github.com/coder/mux) • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh`_ --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `bash.00`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.00 --> Change-Id: I6fbf3726ecce93ef0c389cde239d99d372d11b6d
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes Coder control plane pod crashes caused by a duplicated
serverargument when using the officialghcr.io/coder/coderimage.Background
The reconciler generated pod args beginning with
server, while the image entrypoint already executes/opt/coder server. That produced an effective command equivalent tocoder server server ..., which failed withunrecognized subcommand "server"and caused CrashLoopBackOff.Implementation
["server", "--http-address=0.0.0.0:3000"]["--http-address=0.0.0.0:3000"]spec.extraArgsbehavior unchanged (still appended).extraArgs.Validation
make testmake buildmake lintmake verify-vendor(fails currently due external module checksum mismatch forgithub.com/MirrexOne/unqueryvet@v1.4.0, unrelated to this change)CoderControlPlaneserverRisks
Low. The change is tightly scoped to default argument composition for one container in the reconciler. Main regression risk is deployments that depended on the previous incorrect duplicated subcommand behavior; this is unlikely and test coverage now guards expected args.
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhighGenerated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:98679{COSTS}